On 9/15/18 1:03 AM, Christoph Hellwig wrote: > On Wed, Sep 05, 2018 at 11:33:35AM +0800, Ming Lei wrote: >> It is pointed that bio_rewind_iter() is one very bad API[1]: >> >> 1) bio size may not be restored after rewinding >> >> 2) it causes some bogus change, such as 5151842b9d8732 (block: reset >> bi_iter.bi_done after splitting bio) >> >> 3) rewinding really makes things complicated wrt. bio splitting >> >> 4) unnecessary updating of .bi_done in fast path >> >> [1] https://marc.info/?t=153549924200005&r=1&w=2 > > Based on that this is a bug fix and should go to 4.19 instead of 4.20 > as it is queued up right now.. It's not a new issue (in fact not even close, we're about a year back), hence not a strong reason to shove it into 4.19 vs 4.20. I'm fine with subsequently marking it for stable. -- Jens Axboe
