On Tue, Sep 11, 2018 at 2:51 PM Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:
>
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> drivers/block/rsxx/cregs.c:279:15: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((cmd->op == CREG_OP_READ)) {
> ~~~~~~~~^~~~~~~~~~~~~~~
> drivers/block/rsxx/cregs.c:279:15: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((cmd->op == CREG_OP_READ)) {
> ~ ^ ~
> drivers/block/rsxx/cregs.c:279:15: note: use '=' to turn this equality
> comparison into an assignment
> if ((cmd->op == CREG_OP_READ)) {
> ^~
> =
> 1 warning generated.
>
> Reported-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---
> drivers/block/rsxx/cregs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rsxx/cregs.c b/drivers/block/rsxx/cregs.c
> index c148e83e4ed7..d9a8758682c9 100644
> --- a/drivers/block/rsxx/cregs.c
> +++ b/drivers/block/rsxx/cregs.c
> @@ -276,7 +276,7 @@ static void creg_cmd_done(struct work_struct *work)
> st = -EIO;
> }
>
> - if ((cmd->op == CREG_OP_READ)) {
> + if (cmd->op == CREG_OP_READ) {
> unsigned int cnt8 = ioread32(card->regmap + CREG_CNT);
>
> /* Paranoid Sanity Checks */
> --
> 2.18.0
>
LGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
--
Thanks,
~Nick Desaulniers
