On 05/09/18 01:26 PM, Jens Axboe wrote: > On 9/3/18 4:26 PM, Logan Gunthorpe wrote: >> I personally agree with Christoph. But if there's consensus in the other >> direction or this is a real blocker moving this forward, I can remove it >> for the next version. > > It's a simple branch because the check isn't exhaustive. It just checks > the first page. At that point you may as well just require the caller to > flag the bio/rq as being P2P, and then do a check for P2P compatibility > with the queue. Hmm, we had something like that in v4[1] but it just seemed redundant to create a flag when the information was already in the bio and kind of ugly for the caller to check for, then set, the flag. I'm not _that_ averse to going back to that though... Logan [1] https://lore.kernel.org/lkml/20180423233046.21476-8-logang@xxxxxxxxxxxx/T/#u
