Re: [PATCH] blk-wbt: don't maintain inflight counts if disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 23, 2018 at 09:15:27AM -0600, Jens Axboe wrote:
> A previous commit removed the ability to have per-rq flags. We used
> those flags to maintain inflight counts. Since we don't have those
> anymore, we have to always maintain inflight counts, even if wbt is
> disabled. This is clearly suboptimal.
> 
> Add a queue quiesce around changing the wbt latency settings from sysfs
> to work around this. With that, we can reliably put the enabled check in
> our bio_to_wbt_flags(), since we know the WBT_TRACKED flag will be
> consistent for the lifetime of the request.
> 
> Fixes: Fixes: c1c80384c8f ("block: remove external dependency on wbt_flags")
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> 

Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx>

Sorry about that,

Josef



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux