On 8/22/18 2:39 PM, Linus Torvalds wrote: > On Wed, Aug 22, 2018 at 10:54 AM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> - Set of bcache fixes and changes (Coly) > > Some of those bcache style fixes look questionable. > > Maybe we should push back on some of the checkpatch rules instead? > > Like having argument names in declarations - sometimes descriptive > names can be good documentation. And sometimes they are just noise, > because the type is what describes it. > > Oh well. Taken. Thanks - fwiw, I don't disagree, and I tend to push back harder on this in core code than drivers. Especially for newer maintainers, as it can sometimes be a way to dabble around in the code and find "real" issues. -- Jens Axboe
