On Thu, 16 Aug 2018 12:49:17 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > Hmm, why not just do this? Does this fix it too?
> >
> > Ah, yes, but we need to clear "ret" in that case.
>
> Sure.
>
> >
> > Thanks!
> >
> > >
> > > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> > > index 987d9a9ae283..10b2b9c5fd25 100644
> > > --- a/kernel/trace/blktrace.c
> > > +++ b/kernel/trace/blktrace.c
> > > @@ -1841,6 +1841,8 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev,
> > > mutex_lock(&q->blk_trace_mutex);
> > >
>
> > > if (attr == &dev_attr_enable) {
> > > + if (!!value == !!q->blk_trace) {
> + ret = 0;
> > > + goto out_unlock_bdev;
> + }
>
OK, I tested and ensured that this works.
Tested-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
Thanks!
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
