On Mon, 2018-07-30 at 09:12 +-0200, Hannes Reinecke wrote: +AD4- +AEAAQA- -3061,11 +-3066,7 +AEAAQA- static void nvme+AF8-alloc+AF8-ns(struct nvme+AF8-ctrl +ACo-ctrl, unsigned nsid) +AD4- +AD4- nvme+AF8-get+AF8-ctrl(ctrl)+ADs- +AD4- +AD4- - device+AF8-add+AF8-disk(ctrl-+AD4-device, ns-+AD4-disk, NULL)+ADs- +AD4- - if (sysfs+AF8-create+AF8-group(+ACY-disk+AF8-to+AF8-dev(ns-+AD4-disk)-+AD4-kobj, +AD4- - +ACY-nvme+AF8-ns+AF8-id+AF8-attr+AF8-group)) +AD4- - pr+AF8-warn(+ACIAJQ-s: failed to create sysfs group for identification+AFw-n+ACI-, +AD4- - ns-+AD4-disk-+AD4-disk+AF8-name)+ADs- +AD4- +- device+AF8-add+AF8-disk(ctrl-+AD4-device, ns-+AD4-disk, nvme+AF8-ns+AF8-id+AF8-attr+AF8-groups)+ADs- +AD4- if (ns-+AD4-ndev +ACYAJg- nvme+AF8-nvm+AF8-register+AF8-sysfs(ns)) +AD4- pr+AF8-warn(+ACIAJQ-s: failed to register lightnvm sysfs group for identification+AFw-n+ACI-, +AD4- ns-+AD4-disk-+AD4-disk+AF8-name)+ADs- Hello Hannes, Have you noticed that nvme+AF8-nvm+AF8-register+AF8-sysfs() also registers sysfs attributes and hence that the attributes registered by that function should be merged into the nvme+AF8-ns+AF8-id+AF8-attr+AF8-groups array? Thanks, Bart.
