On Wed, 2018-08-08 at 16:21 +-0800, Ming Lei wrote: +AD4- On Tue, Aug 07, 2018 at 03:51:25PM -0700, Bart Van Assche wrote: +AD4- +AD4- The RQF+AF8-PREEMPT flag is used for three purposes: +AD4- +AD4- - In the SCSI core, for making sure that power management requests +AD4- +AD4- are executed if a device is in the +ACI-quiesced+ACI- state. +AD4- +AD4- - For domain validation by SCSI drivers that use the parallel port. +AD4- +AD4- - In the IDE driver, for IDE preempt requests. +AD4- +AD4- I think the above description may not be accurate, BLK+AF8-MQ+AF8-REQ+AF8-PREEMPT is +AD4- always set inside scsi+AF8-execute(), that means any scsi+AF8-execute() callers +AD4- can use the flag of RQF+AF8-PREEMPT, of course, not limited to the above +AD4- three cases. Hello Ming, What I described is for which cases we really need the RQF+AF8-PREEMPT flag rather than in which cases the RQF+AF8-PREEMPT flag is set today. I think we should split the RQF+AF8-PREEMPT flag into three flags, one flag per case mentioned above. Bart.
