On Fri, 2018-08-03 at 08:11 +-0800, Ming Lei wrote: +AD4- On Fri, Aug 03, 2018 at 12:08:54AM +-0000, Bart Van Assche wrote: +AD4- +AD4- On Fri, 2018-08-03 at 07:53 +-0800, Ming Lei wrote: +AD4- +AD4- +AD4- blk+AF8-pm+AF8-add+AF8-request() calls pm+AF8-request+AF8-resume() for waking up device, but +AD4- +AD4- +AD4- it is wrong because it is async request, which can't guarantee device +AD4- +AD4- +AD4- will be ready before calling .queue+AF8-rq(). +AD4- +AD4- +AD4- +AD4- That's a longstanding issue and not something that has been introduced by this +AD4- +AD4- patch series. Hence patch 6/9 that issues a warning if pm+AF8-request+AF8-resume() would +AD4- +AD4- be called. +AD4- +AD4- It is introduced by your patch, please see blk+AF8-pm+AF8-allow+AF8-request(). Did you perhaps misread my patch? Please have a look at commit c8158819d506 (+ACI-block: implement runtime pm strategy+ACI-). I think that commit from 2013 introduced the pm+AF8-request+AF8-resume() call in blk+AF8-pm+AF8-add+AF8-request(). By the way, if you would like to see that call removed, I'm fine with removing that call. Thanks, Bart.
