On Tue, 2018-07-31 at 13:12 -0700, hch+AEA-infradead.org wrote: +AD4- It shouldn't. All these are built into scsi+AF8-mod.o, which is only built +AD4- when CONFIG+AF8-SCSI is set. Under what circumstances do you see them built? Although I think you are right, I still prefer that the scsi+AF8-common.c file would be moved to a new directory. That will prevent confusion later on for people who want to add additional code. This patch makes it nontrivial to figure out which code is built when SCSI target functionality is enabled but SCSI initiator functionality is not selected. I think moving scsi+AF8-common.c into a new directory would make it much easier to figure out which code is built depending on the kernel configuration. Bart.
