On Mon, Jul 30, 2018 at 09:12:23AM +0200, Hannes Reinecke wrote: > Update device_add_disk() to take an 'groups' argument so that > individual drivers can register a device with additional sysfs > attributes. > This avoids race condition the driver would otherwise have if these > groups were to be created with sysfs_add_groups(). > > Signed-off-by: Martin Wilck <martin.wilck@xxxxxxxx> > Signed-off-by: Hannes Reinecke <hare@xxxxxxxx> The first signoff should always be the author. Otherwise this looks fine (modulo any context changes due to patch 1): Reviewed-by: Christoph Hellwig <hch@xxxxxx>
