On Fri, Jul 27, 2018 at 03:17:11PM -0600, Jens Axboe wrote: > On 7/27/18 3:14 PM, Josef Bacik wrote: > > We need to check in blkcg_bio_issue_check if the bio is flagged as > > QUEUE_ENTERED, because if it is then we've already accounted for the IO > > in the cgroup stats. > > That's a bit of a flag overload, I think that at least warrants a > comment. Yeah I'm not a fan of it, but there's nothing else to indicate that the bio is a split bio other than checking if it's endio is the chain endio. I'll respin with the comment. Thanks, Josef