Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: dgilbert@xxxxxxxxxxxx
Subject: Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
From: Keith Busch <keith.busch@xxxxxxxxxxxxxxx>
Date: Tue, 24 Jul 2018 20:48:16 -0600
Cc: Bart Van Assche <bart.vanassche@xxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Jianchao Wang <jianchao.w.wang@xxxxxxxxxx>, linux-nvme@xxxxxxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <70619fc4-3b98-4213-0d4e-aa7aa248f88d@interlog.com>
References: <20180723143751.10843-1-keith.busch@intel.com> <20180723143751.10843-2-keith.busch@intel.com> <86e23e58-6f80-7957-30f7-8b0ce8cb50ce@wdc.com> <20180725011543.GA14596@localhost.localdomain> <70619fc4-3b98-4213-0d4e-aa7aa248f88d@interlog.com>
User-agent: Mutt/1.9.1 (2017-09-22)

On Tue, Jul 24, 2018 at 09:56:35PM -0400, dgilbert@xxxxxxxxxxxx wrote:
> No LLD should be calling scsi_finish_command() IMO.

Agreed. I don't even think scsi's error handler should directly call it
either, but detangling that may take some time, if ever.

References:
- [PATCHv2 1/2] blk-mq: export setting request completion state
  - From: Keith Busch
- [PATCHv2 2/2] scsi: set timed out out mq requests to complete
  - From: Keith Busch
- Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
  - From: Bart Van Assche
- Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
  - From: Keith Busch
- Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
  - From: Douglas Gilbert

Prev by Date: Re: [PATCH v4 1/3] lib: add crc64 calculation routines
Next by Date: Re: [PATCH v4 3/3] lib/test_crc: Add test cases for crc calculation
Previous by thread: Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
Next by thread: Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]