On Mon, Jul 23, 2018 at 09:54:38PM -0400, Martin K. Petersen wrote: > > Christoph, > > >> +void blk_integrity_dif_prepare(struct request *rq, u8 protection_type, > >> + u32 ref_tag) > >> +{ > > > > Maybe call this blk_t10_pi_prepare? > > The rest of these functions have a blk_integrity_ prefix. So either > stick with that or put the functions in t10-pi.c and use a t10_pi_ > prefix. Yes, I suggested moving it somewhere in my reply.