On Sat, Jul 14, 2018 at 6:29 AM, Martin Wilck <mwilck@xxxxxxxx> wrote: > Hi Ming & Jens, > > On Fri, 2018-07-13 at 12:54 -0600, Jens Axboe wrote: >> On 7/12/18 5:29 PM, Ming Lei wrote: >> > >> > Maybe you can try the following patch from Christoph to see if it >> > makes a >> > difference: >> > >> > https://marc.info/?l=linux-kernel&m=153013977816825&w=2 >> >> That's not a bad idea. > > Are you saying that the previous "nasty hack" in > bio_iov_iter_get_pages() was broken, and the new one is not? > I've scratched my head over that (old) code lately, but I couldn't spot > an actual error in it. Yeah, I think the new patch in above link is better, and looks its correctness is easy to prove. https://marc.info/?t=152812081400001&r=1&w=2 So please test the patch if possible. Thanks, Ming Lei