On Thu, Jul 12, 2018 at 09:17:58AM +0200, Christoph Hellwig wrote: > On Thu, Jul 12, 2018 at 09:36:49AM +0800, Ming Lei wrote: > > > As far as I can tell only ufs and libata support runtime PM, so > > > we should probably only enable it for those. > > > > For legacy path, blk_pm_runtime_init() is always run for all SCSI devices, > > and this patch just follows the old way, so that we can keep runtime PM > > behaviour not changed from user view. That means if we want to only enable > > for ufs & libata, it should be in another standalone patch, instead of > > this one. > > Please add this to the series as a separate patch then. blk_pm_runtime_init() is called from sd/sr, that means all sd/sr device may support runtime PM. And the command of START_STOP will be run for runtime suspend/resume at least even though the host isn't involved. Thanks, Ming