On 7/11/18 8:28 AM, Josef Bacik wrote: > On Wed, Jul 11, 2018 at 08:22:28AM -0600, Jens Axboe wrote: >> On 7/11/18 7:30 AM, Josef Bacik wrote: >>> max_depth used to be a u64, but I changed it to a unsigned int but >>> didn't convert my comparisons over everywhere. Fix by comparing to >>> INT_MAX instead of (u64)-1. >> >> Should that be UINT_MAX? >> > > Hmm I suppose it should, though I'm really just using it to indicate that we're > unthrottled so it doesn't matter a whole lot. Would you prefer I just switch it > all over to UINT_MAX? Thanks, Just seems cleaner, since it's the max of the type. Looks like you'd need to change two spots that already set it to INT_MAX too. -- Jens Axboe
