Re: [PATCH V2 2/3] blk-mq: only attempt to merge bio if there is rq in sw queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 29, 2018 at 04:12:51PM +0800, Ming Lei wrote:
> Only attempt to merge bio iff the ctx->rq_list isn't empty, because:
> 
> 1) for high-performance SSD, most of times dispatch may succeed, then
> there may be nothing left in ctx->rq_list, so don't try to merge over
> sw queue if it is empty, then we can save one acquiring of ctx->lock
> 
> 2) we can't expect good merge performance on per-cpu sw queue, and missing
> one merge on sw queue won't be a big deal since tasks can be scheduled from
> one CPU to another.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux