Re: Subject: [PATCH RFC] block: fix Amiga RDB partition support for disks >= 2 TB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Error NNNN: Conventional RDBs cannot define more than 4,294,967,296 blocks.
or
Error NNNN: Conventional RDB block count overflow.

That is a HARD limit. The documentation for error NNNN should suggest larger logical block (cluster, whatever) sizes as a way out. Of course, block size "could" go up to at least 65536 bytes (if the nonsense size 0 is reinterpreted). Then Bob's your uncle up to 281 TB. It should also include a dry notation that you are best off with a power of 2 block size larger than or equal to the disk's actual sector size, if you can learn that.

{^_^}
(Get everybody)

On 20180627 01:24, Martin Steigerwald wrote:
Thanks a lot again for your patch.

schmitzmic@xxxxxxxxx - 27.06.18, 03:24:
+               if (start_sect > INT_MAX || nr_sects > INT_MAX
+                       || (start_sect + nr_sects) > INT_MAX) {
+                       pr_err("%s: Warning: RDB partition
overflow!\n", +                               bdevname(state->bdev,

I´d word this:

Warning: RDB partition 32-bit overflow

AmigaOS developers can do 64 bit math on a 32 bit operating system. Just
like Linux can.

b));
+                       pr_err("%s: start 0x%llX size 0x%llX\n",
+                               bdevname(state->bdev, b), start_sect,
+                               nr_sects);
+                       pr_err("%s: partition incompatible with 32 bit
OS\n", +                               bdevname(state->bdev, b));
+               }

And as stated in my other reply to the patch:

partition needs 64 bit disk device support in AmigaOS or AmigaOS like
operating systems (NSD64, TD64 or SCSI direct)

see my other reply to the patch and my other mails in the
"Re: moving affs + RDB partition support to staging?" thread as to why.
And for references.

Thanks,




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux