On Fri, Jun 22, 2018 at 03:19:31PM -0700, Bart Van Assche wrote: > Hello Omar, > > As promised during LSF/MM, I have converted the srp-tests software to the > blktests framework. This patch series included all blktests patches I postd > a few days ago. Please consider this patch series for inclusion in the > official blktests repository. Note: this patch series is also available as > a github pull request, namely https://github.com/osandov/blktests/pull/24. > > Thanks, > > Bart. > > Bart Van Assche (15): > common/rc: Fix _have_tracepoint() > Annotate include statements in shell scripts where the source file is > a variable > check, tests/meta/012: Use array["index"] instead of array[index] > Suppress shellcheck complaints about global variables > check: Avoid that shellcheck complains that $FULL appears unused > Multiple tests: remove unused and undefined variables > Avoid passing tests/block/002 arguments to _init_scsi_debug > check: Suppress a shellcheck warning about the DMESG_FILTER > initialization > Makefile: Do not suppress useful shellcheck warnings > tests/meta/group: Fix shellcheck complaints > make check: Also check tests/*/group files > check: Make TMPDIR absolute I've applied all of these. > src/Makefile: Fix pattern rule > Add the discontiguous-io test program > Add tests for the SRP initiator and target drivers For these, can you please reroll them with whatever group_requires() check you need, and with the helper functions moved to tests/srp/rc. Thanks!
