Re: [PATCH blktests 13/15] src/Makefile: Fix pattern rule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 22, 2018 at 03:19:44PM -0700, Bart Van Assche wrote:
> According to the GNU make documentation, the syntax for pattern rules
> is as follows:
> 
> <target pattern>+: <source pattern>
> 	<rule>

That's because this is a static pattern rule:

https://www.gnu.org/software/make/manual/html_node/Static-Usage.html

So calling this a fix isn't accurate :) I'll fold this change into the
change adding the C++ program.

> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> ---
>  src/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/Makefile b/src/Makefile
> index 612282d14af8..d7ae832fc4fd 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -13,7 +13,7 @@ all: $(TARGETS)
>  clean:
>  	rm -f $(TARGETS)
>  
> -$(TARGETS): %: %.c
> +%: %.c
>  	$(CC) -Wall -o $@ $(CPPFLAGS) $(CFLAGS) $^
>  
>  .PHONY: all clean
> -- 
> 2.17.1
> 



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux