On 6/19/18 10:40 AM, Christoph Hellwig wrote: > blk_mq_complete_request can only be called for blk-mq drivers, but when > removing the BLK_EH_HANDLED return value, two legacy request timeout > methods incorrectly got switched to call blk_mq_complete_request. > Call __blk_complete_request instead to reinstance the previous behavior. > For that __blk_complete_request needs to be exported. Yikes. Looks like blktests only smoke tests blk-mq timeout handling, we should add a test to do the same for !mq. -- Jens Axboe