On 2018/6/19 12:52 PM, Christoph Hellwig wrote:
> We immediately overwrite the biovec array, so instead just allocate
> a new bio and copy over the disk, setor and size.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
It looks good to me. Acked-by: Coly Li <colyli@xxxxxxx>
Thanks.
Coly Li
> ---
> drivers/md/bcache/debug.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
> index d030ce3025a6..04d146711950 100644
> --- a/drivers/md/bcache/debug.c
> +++ b/drivers/md/bcache/debug.c
> @@ -110,11 +110,15 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio)
> struct bio_vec bv, cbv;
> struct bvec_iter iter, citer = { 0 };
>
> - check = bio_clone_kmalloc(bio, GFP_NOIO);
> + check = bio_kmalloc(GFP_NOIO, bio_segments(bio));
> if (!check)
> return;
> + check->bi_disk = bio->bi_disk;
> check->bi_opf = REQ_OP_READ;
> + check->bi_iter.bi_sector = bio->bi_iter.bi_sector;
> + check->bi_iter.bi_size = bio->bi_iter.bi_size;
>
> + bch_bio_map(check, NULL);
> if (bch_bio_alloc_pages(check, GFP_NOIO))
> goto out_put;
>
>
