> On 16 Jun 2018, at 21.27, Matias Bjørling <mb@xxxxxxxxxxx> wrote:
>
> On 06/16/2018 12:27 AM, Igor Konopko wrote:
>> Since we have flexible size of pblk_sec_meta
>> which depends on drive metadata size we can
>> remove not needed reserved field from that
>> structure
>> Signed-off-by: Igor Konopko <igor.j.konopko@xxxxxxxxx>
>> ---
>> drivers/lightnvm/pblk.h | 1 -
>> 1 file changed, 1 deletion(-)
>> diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h
>> index f82c3a0b0de5..27658dc6fc1a 100644
>> --- a/drivers/lightnvm/pblk.h
>> +++ b/drivers/lightnvm/pblk.h
>> @@ -82,7 +82,6 @@ enum {
>> };
>> struct pblk_sec_meta {
>> - u64 reserved;
>> __le64 lba;
>> };
>>
>
> Looks good to me. Javier may have some comment on this, since it is
> not completely obvious from the code why that reserved attribute is
> there. I do like the change to go in, as it needlessly extends the
> requirement from 8 to 16bytes.
Looks good to me. Maybe marge this patch with 1/5? It was actually a
comment I added to it.
Attachment:
signature.asc
Description: Message signed with OpenPGP
