On 6/14/18 7:38 AM, Hannes Reinecke wrote: > For performance reasons we should be able to allocate all memory > from a given NUMA node, so this patch adds a new parameter > 'rd_numa_node' to allow the user to specify the NUMA node id. > When restricing fio to use the same NUMA node I'm seeing a performance > boost of more than 200%. Looks fine to me. One comment. > @@ -342,6 +343,10 @@ static int max_part = 1; > module_param(max_part, int, 0444); > MODULE_PARM_DESC(max_part, "Num Minors to reserve between devices"); > > +static int rd_numa_node = NUMA_NO_NODE; > +module_param(rd_numa_node, int, 0444); > +MODULE_PARM_DESC(rd_numa_node, "NUMA node number to allocate RAM disk on."); This could feasibly be 0644, as there would be nothing wrong with altering this at runtime. -- Jens Axboe
