On Wed, Jun 13, 2018 at 11:39:20PM -0700, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 10:01:38AM +0800, Ming Lei wrote: > > Bounce limits the max pages as 256 will do bio splitting, so won't need > > this change. > > Behavior for the bounce code does not change with my patch. > > The important points are: > > - the default interface (bio_clone_bioset in this case) should always > operate on full biosets > - if the bounce code needs bioves limited to single pages it should > be treated as the special case > - given that the bounce code is inside the block layer using the > __-prefixed internal interface is perfectly fine > - last but not least I think the parameter switching the behavior > needs a much more descriptive name as suggested in my patch Fair enough, will switch to this way and avoid DM's change, even though it is a dying interface. Thanks, Ming
