On Tue, Jun 05, 2018 at 10:04:56PM +0900, Tetsuo Handa wrote: > I noticed that this patch is forgotten at ext4.git#loop-fix and therefore > is not available at linux-next.git . Please be sure to include for 4.18 . I was assuming Jens was going to send it to Linus, after he does a review. I could send a pull request to Linus directly, but while I was the original author of loop driver, that was like two decades ago (and LOOP_CHANGE_FD was *not* my idea), and normally loop driver changes goes up to Linus through the block tree, I believe. Cheers, - Ted > > On 2018/05/08 0:37, Theodore Ts'o wrote: > > Refactor the validation code used in LOOP_SET_FD so it is also used in > > LOOP_CHANGE_FD. Otherwise it is possible to construct a set of loop > > devices that all refer to each other. This can lead to a infinite > > loop in starting with "while (is_loop_device(f)) .." in loop_set_fd(). > > > > Fix this by refactoring out the validation code and using it for > > LOOP_CHANGE_FD as well as LOOP_SET_FD. > > > > Reported-by: syzbot+4349872271ece473a7c91190b68b4bac7c5dbc87@xxxxxxxxxxxxxxxxxxxxxxxxx > > Reported-by: syzbot+40bd32c4d9a3cc12a339@xxxxxxxxxxxxxxxxxxxxxxxxx > > Reported-by: syzbot+769c54e66f994b041be7@xxxxxxxxxxxxxxxxxxxxxxxxx > > Reported-by: syzbot+0a89a9ce473936c57065@xxxxxxxxxxxxxxxxxxxxxxxxx > > Signed-off-by: Theodore Ts'o <tytso@xxxxxxx> > > --- > > drivers/block/loop.c | 68 +++++++++++++++++++++++++++++----------------------- > > 1 file changed, 38 insertions(+), 30 deletions(-) > >
