ACK. the patch is OK for me > -----Original Message----- > From: Wang YanQing [mailto:udknight@xxxxxxxxx] > Sent: Tuesday, June 05, 2018 5:39 PM > To: axboe@xxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > pombredanne@xxxxxxxx; tglx@xxxxxxxxxxxxx; Caizhiyong > <caizhiyong@xxxxxxxxxxxxx>; rdunlap@xxxxxxxxxxxxx; Jiangheng > <jiangheng@xxxxxxxxxxxxx>; linux-block@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v5] block: add verifier for cmdline partition > > On Thu, May 10, 2018 at 11:06:37AM +0800, Wang YanQing wrote: > > I meet strange filesystem corruption issue recently, the reason > > is there are overlaps partitions in cmdline partition argument. > > > > This patch add verifier for cmdline partition, then if there are > > overlaps partitions, cmdline_partition will log a warning. We don't > > treat overlaps partition as a error: > > " > > Caizhiyong <caizhiyong@xxxxxxxxxxxxx> said: > > Partition overlap was intentionally designed in this cmdline partition. > > reference http://lists.infradead.org/pipermail/linux-mtd/2013- > August/048092.html > > " > > > > Signed-off-by: Wang YanQing <udknight@xxxxxxxxx> > > --- > > Changes > > v4-v5: > > 1:Delete unnecessary blank line at begin and end of logs. > > 2:Delete newline character in log, pr_* will add newline > > automatically. > > > > v3-v4: > > 1:Fix grammar typo, reported by Randy Dunlap. > > 2:Delete unnecessary type casting, reported by Caizhiyong. > > 3:Record the reason why we can't treat overlapping partitions > > as errors into changelog. > > > > v2-v3: > > 1:Fix log one pair of overlaps partitions twice in cmdline_parts_verifier. > > 2:Fix out of bound access in cmdline_parts_verifier. > > > > v1-v2: > > 1:Don't treat overlaps partition as a error, but log a warning. > > > > Hi! Jens Axboe > > > > What is your suggestion? > Hi! All > > I just want to know what is the status about this patch? > > ACK or NACK is welcome. > > Thanks
