On 5/31/18 1:47 AM, Ladvine D Almeida wrote: > On Monday 28 May 2018 04:54 PM, Jens Axboe wrote: >> On 5/28/18 7:43 AM, Ladvine D Almeida wrote: >>> This patch introduces new variable under bio structure to >>> facilitate inline encryption. This variable is used to >>> associate I/O requests to crypto information. >> Hard no on this, for two reasons: >> >> 1) Any additions to struct bio are scrutinized heavily and >> need strong justification. > > Thanks for sharing your feedback on the patch. > I am providing reference to an earlier article related to inline encryption support below: > https://lwn.net/Articles/717754/ Took a quick look, and this looks like a classic case of something that should just be a cloned bio. If you clone, you own the bi_private field, which is what you need. -- Jens Axboe
