> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxx] > Sent: Tuesday, May 29, 2018 10:30 AM > To: Verkamp, Daniel <daniel.verkamp@xxxxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx>; linux-nvme@xxxxxxxxxxxxxxxxxxx; Jens Axboe > <axboe@xxxxxxxxx>; linux-block@xxxxxxxxxxxxxxx; Hannes Reinecke > <hare@xxxxxxxx>; Sagi Grimberg <sagi@xxxxxxxxxxx>; Busch, Keith > <keith.busch@xxxxxxxxx>; Hannes Reinecke <hare@xxxxxxx> > Subject: Re: [PATCH 09/14] nvmet: Add AEN configuration support > > On Tue, May 29, 2018 at 05:15:34PM +0000, Verkamp, Daniel wrote: > > This looks overly restrictive - a host sending a Set Features with e.g. the health > critical warning bits set in CDW11 will get a failure. As far as I can tell, this isn't > allowed by the spec; Set Features - Asynchronous Event Configuration and the > health log page have been mandatory since NVMe 1.0, and presumably support > for the corresponding health log page related AER bits is also mandatory (these > were the only bits available in NVMe 1.0). > > Agreed so far. > > > I think it should be fine to just allow the user to set any (valid) combination of > bits here, while still only triggering the NS Changed notification. > > Disagreeing here. Catching completely bogus bits that the hosts sets > is important. Sorry, I should have been clearer - I agree with your position here. Only bits that are valid should be allowed, so for example it is fine to fail commands that set reserved bits, or optional bits that have a mechanism to indicate they are not supported, like Telemetry (which has an associated bit in Identify controller data - LPA). My note above was really just about the health warning bits, which by my reading are not optional. Thanks, -- Daniel
