Re: [PATCH] blk-mq: remove wrong 'unlikely' checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/22/18 3:39 AM, huhai wrote:
> When dispatch_rq_from_ctx is called, in the vast majority of cases
> the ctx->rq_list is not empty

I'm fine with killing it, generally I dislike the likely/unlikely
annotations unless the intent is absolutely clear. This one is not.

> Fixes: b347689ffbca ("blk-mq-sched: improve dispatching from sw queue")

Though for this one, I'll drop the fixes tag as it isn't something we
need to backport to stable and it's not really fixing a real bug that
is causing an issue.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux