Re: [PATCH v2] lib/crc64.c: add license information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/5/22 4:54 PM, Coly Li wrote:
> This patch adds MODULE_LICENSE("GPL") to remove a kernel build warning
> information. Also as Andy Shevchenko suggested, adds a SPDX header into
> lib/crc64.c file.
> 
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Hi Andy,

Could you please to offer a Reviewed-by or Acked-by ? We have an
agreement that every patch should have a peer reviewer, at this moment
we are lack of code reviewer but I still want to keep this rule as much
as I can.

Thanks in advance.

Coly Li

> ---
>  lib/crc64.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/crc64.c b/lib/crc64.c
> index ed0ffac7b26a..30d1bb58dd5c 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group (Any
>   * use permitted, subject to terms of PostgreSQL license; see.)
> @@ -135,3 +136,4 @@ uint64_t crc64(const void *data, size_t len)
>  EXPORT_SYMBOL_GPL(crc64);
>  
>  MODULE_DESCRIPTION("CRC64 calculations");
> +MODULE_LICENSE("GPL");
> 




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux