Re: [PATCH] lib/crc64.c: add MODULE_LICENSE("GPL")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-05-22 at 16:40 +0800, Coly Li wrote:
> This patch adds MODULE_LICENSE("GPL") to lib/crc64.c to remove a
> compiling
> warninng.

I have no opinion about this. Code has a top description from which it
has been taken / derived, so, I dunno if GPL is what it really is.

In any case it's probably worth to add SPDX header as well. 

> 
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  lib/crc64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/crc64.c b/lib/crc64.c
> index ed0ffac7b26a..586e46684ee8 100644
> --- a/lib/crc64.c
> +++ b/lib/crc64.c
> @@ -135,3 +135,4 @@ uint64_t crc64(const void *data, size_t len)
>  EXPORT_SYMBOL_GPL(crc64);
>  
>  MODULE_DESCRIPTION("CRC64 calculations");
> +MODULE_LICENSE("GPL");

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux