Re: [PATCH v4 0/3] AIO add per-command iopriority

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/17/18 7:41 PM, Jens Axboe wrote:
> On 5/17/18 2:38 PM, adam.manzanares@xxxxxxx wrote:
>> From: Adam Manzanares <adam.manzanares@xxxxxxx>
>>
>> This is the per-I/O equivalent of the ioprio_set system call.
>> See the following link for performance implications on a SATA HDD:
>> https://lkml.org/lkml/2016/12/6/495
>>
>> First patch factors ioprio_check_cap function out of ioprio_set system call to
>> also be used by the aio ioprio interface.
>>
>> Second patch converts kiocb ki_hint field to a u16 to avoid kiocb bloat.
>>
>> Third patch passes ioprio hint from aio iocb to kiocb and enables block_dev
>> usage of the per I/O ioprio feature.
>>
>> v2: merge patches
>>      use IOCB_FLAG_IOPRIO
>>      validate intended use with IOCB_IOPRIO
>>      add linux-api and linux-block to cc
>>
>> v3: add ioprio_check_cap function
>>      convert kiocb ki_hint to u16
>>      use ioprio_check_cap when adding ioprio to kiocb in aio.c
>>
>> v4: handle IOCB_IOPRIO in aio_prep_rw
>>      note patch 3 depends on patch 1 in commit msg
>>
>> Adam Manzanares (3):
>>    block: add ioprio_check_cap function
>>    fs: Convert kiocb rw_hint from enum to u16
>>    fs: Add aio iopriority support for block_dev
>>
>>   block/ioprio.c               | 22 ++++++++++++++++------
>>   fs/aio.c                     | 16 ++++++++++++++++
>>   fs/block_dev.c               |  2 ++
>>   include/linux/fs.h           | 17 +++++++++++++++--
>>   include/linux/ioprio.h       |  2 ++
>>   include/uapi/linux/aio_abi.h |  1 +
>>   6 files changed, 52 insertions(+), 8 deletions(-)
> 
> This looks fine to me now. I can pick up #1 for 4.18 - and 2+3 as well,
> unless someone else wants to take them.

Great, thanks Jens.

> 




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux