Re: blk-mq: make sure that correct hctx->dispatch_from is set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/18/18 7:42 AM, 胡海 wrote:
> Author: huhai <huhai@xxxxxxxxxx>
> Date:   Fri May 18 17:09:56 2018 +0800
> 
>     blk-mq: make sure that correct hctx->dispatch_from is set
>     
>     When the number of hardware queues is changed, the drivers will call
>     blk_mq_update_nr_hw_queues() to remap hardware queues, and then
>     the ctx mapped on hctx will also change, but the current code forgets to
>     make sure that correct hctx->dispatch_from is set, and hctx->dispatch_from
>     may point to a ctx that does not belong to the current hctx.

Looks good, thanks. One minor note for future patches - for cases like this,
when the patch fixes an issue with a specific commit, add a fixes line.
For this one, it would be:

Fixes: b347689ffbca ("blk-mq-sched: improve dispatching from sw queue")

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux