> Il giorno 09 mag 2018, alle ore 22:49, Jens Axboe <axboe@xxxxxxxxx> ha scritto: > > Omar had some valid complaints about the previous patchset, mostly > around the fact that we should not be updating depths on a per-IO > basis. He's right. In fact, BFQ oddly enough does it from the > ->limit_depth hook, but the shallow depth counts remain static. > > This series cleans that up the ->limit_depth() handling, and keeps it > out of the hot path. > > Mike, this should (still) fix your hangs with BFQ. This series is > (functionally) identical to the bundled up version I sent you earlier. > Only one question/curiosity: is performance unaffected by the lowering of the wake batch counts? Apart from that, Acked-by: Paolo Valente <paolo.valente@xxxxxxxxxx> Thanks, Paolo > block/bfq-iosched.c | 113 +++++++++++++++++++++++++----------------------- > block/bfq-iosched.h | 6 -- > block/blk-mq.c | 6 +- > block/kyber-iosched.c | 3 + > include/linux/sbitmap.h | 11 ++++ > lib/sbitmap.c | 19 +++++++- > 6 files changed, 95 insertions(+), 63 deletions(-) > > -- > Jens Axboe >
