On 5/7/18 3:51 AM, Christoph Hellwig wrote: > On Thu, May 03, 2018 at 09:20:41AM -0600, Jens Axboe wrote: >> Don't build discards bigger than what the user asked for, if the >> user decided to limit the size by writing to 'discard_max_bytes'. >> >> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > > Why do this here when blk_bio_discard_split already takes care of it? Functionally it should be the same, just seems pointless to defer the chopping if we can build them the right size to begin with. -- Jens Axboe
