Jens Axboe wrote: > On 5/4/18 10:14 AM, Tetsuo Handa wrote: > >>>> If that's not easily done, then my next suggestion would be to > >>>> use a loop flag for it, LO_FLAGS_SYSFS_SETUP or something like that. > >>> > >>> Yes, that would be possible. > >> > >> Let's make that change. > > > > Since LO_FLAGS_* are defined in include/uapi/linux/loop.h as userspace visible > > flags, I feel that using "struct loop_device"->lo_flags for recording whether > > sysfs entry exists might be strange... Anyway, updated patch is shown below. > > Hmm yes, I forgot about that, I guess that makes the flags approach > pretty much useless. Let's just go with your v1 in that case. > OK. You can s/sysfs_ready/sysfs_init_done/ before you apply to your tree.