On 5/4/18 5:47 AM, Tetsuo Handa wrote: >>From 626d33de1b70b11ecaf95a9f83f7644998e54cbb Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> > Date: Wed, 2 May 2018 23:03:48 +0900 > Subject: [PATCH] loop: remember whether sysfs_create_group() succeeded > > syzbot is hitting WARN() triggered by memory allocation fault > injection [1] because loop module is calling sysfs_remove_group() > when sysfs_create_group() failed. > Fix this by remembering whether sysfs_create_group() succeeded. Can we store this locally instead of in the loop_device? Also, naming wise, something like sysfs_init_done would be more readily understandable. -- Jens Axboe