On Wed, Apr 25, 2018 at 08:30:36AM -0700, Omar Sandoval wrote:
[...]
> The TODO comment was leftover here, I removed it.
Oops sorry.
> > +DESCRIPTION="Test nvme and nvmet UUID NS descriptors"
> > +
> > +QUICK=1
> > +
> > +requires() {
> > + _have_program nvme && _have_module nvme-loop && _have_module loop \
> > + && _have_configfs
> > +}
> > +
> > +_find_nvme_loop_dev() {
> > + for dev in /sys/block/nvme*; do
> > + dev="$(basename $dev)"
>
> There's some missing quoting around "$dev" here. There's also some more
> missing quoting, `make shellcheck` will catch this sort of thing.
Thanks, I'll try to not forget running shellcheck. Maybe we should set
up travis on github to catch this?
Johannes
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
