On Tue, Apr 24, 2018 at 03:41:46PM -0600, Keith Busch wrote:
[...]
> +DESCRIPTION="break PCI link while doing I/O"
> +TIMED=1
I _think_ we can set QUICK=1 here, Omar?
> +
> +requires() {
> + _have_fio
> +}
You're using setpci below, so please add it to requires,
i.e. _have_fio && _have_program setpci
> +
> +device_requires() {
> + _test_dev_is_pci
> + _test_hotplug_slot
> +}
I think this sould be _test_dev_is_pci && _test_hotplug_slot
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
