On Wed, Apr 11, 2018 at 7:07 PM, Elliott, Robert (Persistent Memory) <elliott@xxxxxxx> wrote: >> -----Original Message----- >> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Jack Wang >> Sent: Wednesday, April 11, 2018 8:21 AM >> Subject: [PATCH] block: ratelimite pr_err on IO path >> >> From: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxxx> > ... >> - pr_err("%s: ref tag error at location %llu " \ >> - "(rcvd %u)\n", iter->disk_name, >> - (unsigned long long) >> - iter->seed, be32_to_cpu(pi->ref_tag)); >> + pr_err_ratelimited("%s: ref tag error at " >> + "location %llu (rcvd %u)\n", > > Per process/coding-style.rst, you should keep a string like that on > one line even if that exceeds 80 columns: > > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. ... However, never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. > > Thanks Robert, as the original code keep the 80 columns, I just followed, I will fix it in v2. -- Jack Wang Linux Kernel Developer ProfitBricks GmbH Greifswalder Str. 207 D - 10405 Berlin
