On Wed, 2018-04-11 at 10:12 +0800, Ming Lei wrote: > On Tue, Apr 10, 2018 at 02:45:54PM -0600, Bart Van Assche wrote: > > + struct request_queue *q = bio->bi_disk->queue; > > blk_qc_t ret = BLK_QC_T_NONE; > > > > + if (blk_queue_enter(q, flags) < 0) { > > Same issue with V1, the queue pointer has to be checked before calling > blk_queue_enter(). I think it's the responsibility of the caller to keep a reference on the request queue. Bart.