Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bart.vanassche@xxxxxxx>
Subject: Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 9 Apr 2018 11:37:44 +0200
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Israel Rukshin <israelr@xxxxxxxxxxxx>, Max Gurtovoy <maxg@xxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20180409052038.5391-1-bart.vanassche@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

This looks sensible, but I'm worried about taking a whole spinlock
for every request completion, including irq disabling.  However it seems
like your new updated pattern would fit use of cmpxchg() very nicely.

Follow-Ups:
- Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
  - From: Bart Van Assche

References:
- [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
  - From: Bart Van Assche

Prev by Date: Re: usercopy whitelist woe in scsi_sense_cache
Next by Date: Re: [PATCH 1/8] blk-mq: make sure that correct hctx->next_cpu is set
Previous by thread: Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
Next by thread: Re: [PATCH] blk-mq: Fix recently introduced races in the timeout handling code
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux