Re: [PATCH] mmc: block: Delete gendisk before cleaning up the request queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/18 10:59 AM, Bart Van Assche wrote:
> On Thu, 2018-03-22 at 18:56 +0800, Shawn Lin wrote:
>> dd if=/dev/urandom of=/dev/mmcblk1 bs=4k count=10000
>> with a SD card hotplug during transfer reports a warning below
>> introduced by commit a063057d7c73 ("block: Fix a race between
>> request queue removal and the block cgroup controller"). So we
>> should now remove the disk, partition and bdi sysfs attributes
>> before cleaning up the request queue associated with the disk.
> 
> Since del_gendisk() may submit I/O calling blk_cleanup_queue() before
> del_gendisk() has never been safe so this requirement is not really new.
> Anyway, thanks for this patch.

Indeed, it has always been so. In any case, patch does look good,
applied.


-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux