On 16/03/2018 12:52 AM, Bart Van Assche wrote: > On Fri, 2018-03-16 at 00:29 +0800, Coly Li wrote: >> On 15/03/2018 11:08 PM, Bart Van Assche wrote: >>> This patch does not change any functionality but avoids that smatch >>> reports the following: >>> >>> drivers/md/bcache/alloc.c:334: bch_allocator_thread() error: uninitialized symbol 'bucket'. >>> >>> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> >> >> Hi Bart, >> >> Your change is OK to me, but the original code seems OK too. Can I say >> this is a bug should be fixed from smatch ? > > Hello Coly, > > It would be great if smatch would be modified such that it does not complain > about this code. But I think that this patch does not only make the code > easier to analyze for static analyzers but also for humans. So please evaluate > this patch from that perspective. Hi Bart, It's fair enough, I am convinced. Thanks. Reviewed-by: Coly Li <colyli@xxxxxxx> Coly Li
