Re: [PATCH 09/16] bcache: Remove a redundant assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/03/2018 11:08 PM, Bart Van Assche wrote:
> A bio_set_op_attrs() call a little further down overwrites bio->bi_opf.
> That means that the bio->bi_opf assignment is redundant. Hence remove it.
> See also commit ad0d9e76a412 ("bcache: use bio op accessors").
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Mike Christie <mchristi@xxxxxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>

Reviewed-by: Coly Li <colyli@xxxxxxx>

Thanks.

Coly Li

> ---
>  drivers/md/bcache/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 87c1f853bbb3..d19a44cd1fd7 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -353,7 +353,6 @@ static void uuid_io(struct cache_set *c, int op, unsigned long op_flags,
>  	for (i = 0; i < KEY_PTRS(k); i++) {
>  		struct bio *bio = bch_bbio_alloc(c);
>  
> -		bio->bi_opf = REQ_SYNC | REQ_META | op_flags;
>  		bio->bi_iter.bi_size = KEY_SIZE(k) << 9;
>  
>  		bio->bi_end_io	= uuid_endio;
> 




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux