Re: [PATCH 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bart.vanassche@xxxxxxx>
Subject: Re: [PATCH 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Fri, 02 Mar 2018 18:18:16 -0500
Cc: Jens Axboe <axboe@xxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, Johannes Thumshirn <jthumshirn@xxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>
In-reply-to: <20180228192823.5191-11-bart.vanassche@wdc.com> (Bart Van Assche's message of "Wed, 28 Feb 2018 11:28:22 -0800")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Bart,

> Since it is not safe to use queue_flag_(set|clear)_unlocked() without
> holding the queue lock after the sysfs entries for a queue have been
> created, complain if this happens.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

References:
- [PATCH 00/11] Make all concurrent queue flag manipulations safe
  - From: Bart Van Assche
- [PATCH 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused
  - From: Bart Van Assche

Prev by Date: Re: [PATCH 08/11] target/tcm_loop: Use blk_queue_flag_set()
Next by Date: Re: [PATCH 11/11] block: Move the queue_flag_*() functions from a public into a private header file
Previous by thread: Re: [PATCH 10/11] block: Complain if queue_flag_(set|clear)_unlocked() is abused
Next by thread: [PATCH 05/11] mtip32xx: Use the blk_queue_flag_*() functions
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]