>>> This breaks user-space. The intention is for user-space to decide >>> based on version id. Then it can either retrieve the 1.2 or 2.0 >>> attributes. The 2.0 attributes should not be available when a device >>> is 1.2. >>> >> Why does it break it? I'm only adding new entries. >> The objective is to expose the genneric geometry, since this is the >> structure that is passed on to the targets. Since some of the values are >> calculated, there is value on exposing this information, I believe. >> Another way of doing it, is adding the generic geometry at the target >> level, showing what base values it is getting, including the real number >> of channels/groups and luns/pus. >> Would this be better in your opinion? > > No. It should be one set of attributes for 1.2 (keep the way it is today), and then separate 2.0 attributes. User-space should then identify either by either 1 or 2 in the version attribute. > >>>> ... >>> csecs and sos are derived from the the generic block device data structures. >> As mentioned above, it is to represent the generic geometry. > > They are not part of the 2.0 spec. The fields can be derived from elsewhere. >>> Ok. Thanks for looking into it. Javier.
