On Tue, 2018-02-06 at 00:03 +0200, Sagi Grimberg wrote: > +static int irq_am_register_debugfs(struct irq_am *am) > +{ > + char name[20]; > + > + snprintf(name, sizeof(name), "am%u", am->id); > + am->debugfs_dir = debugfs_create_dir(name, > + irq_am_debugfs_root); How is a user expected to figure out which driver am%u is associated with? Please make sure that these directories have a name that makes it easy for users to figure out what driver the moderation settings apply to. Thanks, Bart.